Add structure to SubController hierarchy #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 56.18% 61.73% +5.55%
==========================================
Files 22 22
Lines 817 831 +14
==========================================
+ Hits 459 513 +54
+ Misses 358 318 -40 ☔ View full report in Codecov by Sentry. |
GDYendell
force-pushed
the
sub-controller-structure
branch
2 times, most recently
from
3237ce7
to
a31a9c2
Compare
Store sub controllers in a dictionary by path. This enables a Controller to introspect its SubControllers and their parameters to perform higher level logic, such as fanning out configuration or creating Attributes that give a summary of underlying state (e.g. sum(), any(), all()). Add some exception handling.
Refactor to make it easier to test (and more sensible).
GDYendell
force-pushed
the
sub-controller-structure
branch
from
a31a9c2
to
788ecf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store sub controllers in a dictionary by path. This enables a Controller to introspect its SubControllers and their parmeters to perform higher level logic, such as fanning out configuration or creating Attributes that give a summary of underlying state (e.g. sum(), any(), all()).
Add some exception handling.