Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-128: Add plate view to queue page #839

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-128

NB Due to likely merge conflicts, marking as draft until #829 has been merged.

Summary:

When queuing subsamples in a plate for data collection, it would be useful to show a view of the plate, rather than just a list of (possibly 1000s of) subsamples.

Changes:

  • Move filtering by point/region/manual/auto to the server
  • Display a plate view on the "Prepare For Data Collection" page (/containers/queue/)
  • Add a search bar to the same page
  • Synchronize the search bar with clicking on the plate wells
  • Load the inspection image when you click on the wells
  • Fix site-wide bug where clearing the search box using the x (Chrome-only?) doesn't clear the search parameters

To test:

  • Go to a VMXi proposal, eg nt37104, navigate to the /containers page, click a plate that is 'in storage' and has some subsamples, eg /containers/cid/309228
  • Click on a few wells with subsamples and assign them a 'score', in the top left of the photo of the well, the colour of the well should change depending on the score you give
  • Click "Prepare for Data Collection" to go to eg /containers/queue/309228. Check a view of the plate appears with the same colours as the previous page
  • Check the Point/Region/Manual/Auto filters query the server and display only the relevant subsamples
  • Click on a well on the plate, check the search bar updates to eg A1d1 and only subsamples matching that appear.
  • Click on a well, check the photo of the well changes.
  • Edit the search manually, check the results update
  • Refresh the page, check the search perseveres (as the page URL has /s/searchquery)
  • Delete the search using backspace, check all subsamples are displayed again
  • (In Chrome or Edge), do a search, then clear it using the little [x] that appears, check the search updates correctly (this affects all search boxes on the site)

@ndg63276 ndg63276 marked this pull request as ready for review October 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant