Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup github actions #629

Closed
stan-dot opened this issue Sep 9, 2024 · 4 comments
Closed

Speedup github actions #629

stan-dot opened this issue Sep 9, 2024 · 4 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@stan-dot
Copy link
Contributor

stan-dot commented Sep 9, 2024

They take a long time and if we do some smart caching we could speed this up, freeing up resources.

Resources on that caching
@stan-dot stan-dot self-assigned this Sep 9, 2024
@stan-dot stan-dot added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Sep 9, 2024
@gilesknap
Copy link
Contributor

I have used caching for container builds and it can be very effective. Sometimes 20 minute container builds are reduced to 1 minute.
https://github.com/epics-containers/ioc-adsimdetector/blob/574642e3eb8e6e24d6faca0a427f6b0a854a3bbb/.github/workflows/build.yml#L59-L60
I find there is a some overhead in cache read/write so that for smaller builds this becomes wasteful.

@stan-dot
Copy link
Contributor Author

thanks, I'll look into it

@stan-dot
Copy link
Contributor Author

it would be cool if we could run those actions locally...
https://github.com/nektos/act

@stan-dot stan-dot linked a pull request Sep 25, 2024 that will close this issue
629 speedup GitHub actions #650
Closed
@stan-dot stan-dot mentioned this issue Sep 25, 2024
Closed
@Relm-Arrowny Relm-Arrowny mentioned this issue Oct 4, 2024
Merged
stan-dot pushed a commit that referenced this issue Oct 4, 2024
@Relm-Arrowny
Caches pip download and env (#656)
26be98c 
#650 #629 I made an attempt caching the python env, it gain you about
30-90 per work flow build not sure if it is worth it or not. We can
probably play the same game with the container part of the work-flow
which is where the real bottle neck is.

@stan-dot Anyway see what you think,
stan-dot pushed a commit that referenced this issue Oct 30, 2024
@Relm-Arrowny @stan-dot
Caches pip download and env (#656)
869f9b0 
#650 #629 I made an attempt caching the python env, it gain you about
30-90 per work flow build not sure if it is worth it or not. We can
probably play the same game with the container part of the work-flow
which is where the real bottle neck is.

@stan-dot Anyway see what you think,
@stan-dot
Copy link
Contributor Author

stan-dot commented Nov 4, 2024

this might be revisited in the future, not needed for now

@stan-dot stan-dot removed their assignment Nov 4, 2024
@callumforrester callumforrester closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

629 speedup GitHub actions DiamondLightSource/blueapi
3 participants
@gilesknap @callumforrester @stan-dot