Allow context to deal with new style unions and add tests #436
+24
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 89.38% 89.40% +0.01%
==========================================
Files 43 43
Lines 1800 1802 +2
==========================================
+ Hits 1609 1611 +2
Misses 191 191 ☔ View full report in Codecov by Sentry. |
DominicOram
force-pushed
the
432_new_style_unions_failing
branch
from
233a9be to
e4d11c5
Compare
callumforrester
approved these changes
Apr 26, 2024
| @@ -264,7 +257,7 @@ def _type_spec_for_function( | |||
| ) | |||
| return new_args | |||
|
|
|||
| def _convert_type(self, typ: type) -> type: | |||
| def _convert_type(self, typ: type | Any) -> type: | |||
There was a problem hiding this comment.
Should: We can get rid of the Any when mypy introduces the new, generic TypeForm: python/mypy#9773. There will be a PEP introduced at some point and hopefully TypeForm will be backported up to 3.10. Relatively minor change so unsure if a comment or an issue (or both) is most appropriate here, I'll let you decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432