Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a setter to create_hardware_backed_soft_signal #1077

Open
DominicOram opened this issue Feb 27, 2025 · 1 comment · May be fixed by #1078
Open

Allow passing a setter to create_hardware_backed_soft_signal #1077

DominicOram opened this issue Feb 27, 2025 · 1 comment · May be fixed by #1078

Comments

@DominicOram
Copy link
Contributor

There are many cases where we need a derived signal (see bluesky/ophyd-async#525). In the absence of one in ophyd-async it is preferable that we try and keep the places where we're using derived signals going through one code path in dodal. This is so that the migration to the standard solution is easier.

Currently we have create_hardware_backed_soft_signal which creates a read-only signal but there are cases where the derived signal should be read/write. It is very easy to change create_hardware_backed_soft_signal to do this so it is better to do this now, and keep everyone using the same style/code path, than to wait on bluesky/ophyd-async#525.

Acceptance Criteria

  • create_hardware_backed_soft_signal creates a read/write signal that uses a provided set method for the writing.
@DominicOram
Copy link
Contributor Author

FYI @coretl and @Relm-Arrowny, this will be very useful for #1032 so I'm going to do it now for the above reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant