Allow setting on hardware backed signals #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
src/dodal/common/signal_utils.py
Outdated
|
|
||
|
|
||
| class HardwareBackedSoftSignalBackend(SoftSignalBackend[SignalDatatypeT]): | ||
| def __init__( | ||
| self, | ||
| get_from_hardware_func: Callable[[], Coroutine[Any, Any, SignalDatatypeT]], | ||
| set_to_hardware_func: Callable[[], Coroutine[SignalDatatypeT, Any, Any]] = None, |
There was a problem hiding this comment.
I think set_to_hardware_func should take a set value?
Suggested change
| set_to_hardware_func: Callable[[], Coroutine[SignalDatatypeT, Any, Any]] = None, | |
| set_to_hardware_func: Callable[[SignalDatatypeT], Coroutine[SignalDatatypeT, Any, Any]] | |
| | None = None, |
There was a problem hiding this comment.
Thanks! I missed it 'cos the linter is still broken due to #1072
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
==========================================
- Coverage 97.69% 97.68% -0.02%
==========================================
Files 160 160
Lines 6635 6644 +9
==========================================
+ Hits 6482 6490 +8
- Misses 153 154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+42
to
+48
| def create_rw_hardware_backed_soft_signal( | ||
| datatype: type[SignalDatatypeT], | ||
| get_from_hardware_func: Callable[[], Coroutine[Any, Any, SignalDatatypeT]], | ||
| set_to_hardware_func: SetHardwareType, | ||
| units: str | None = None, | ||
| precision: int | None = None, | ||
| ): |
There was a problem hiding this comment.
never mind, I notice, it will always get overwrite.
Suggested change
| def create_rw_hardware_backed_soft_signal( | |
| datatype: type[SignalDatatypeT], | |
| get_from_hardware_func: Callable[[], Coroutine[Any, Any, SignalDatatypeT]], | |
| set_to_hardware_func: SetHardwareType, | |
| units: str | None = None, | |
| precision: int | None = None, | |
| ): | |
| def create_rw_hardware_backed_soft_signal( | |
| datatype: type[SignalDatatypeT], | |
| get_from_hardware_func: Callable[[], Coroutine[Any, Any, SignalDatatypeT]], | |
| set_to_hardware_func: Callable[[SignalDatatypeT], Coroutine[Any, Any, None]], | |
| initial_value: SignalDatatypeT | None = None, | |
| units: str | None = None, | |
| precision: int | None = None, | |
| ) -> SignalRW: |
There was a problem hiding this comment.
Yh, I think it's an edge case anyway and initial_value is probably never going to be None
src/dodal/common/signal_utils.py
Outdated
| precision=precision, | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| def create_hardware_backed_soft_signal( |
There was a problem hiding this comment.
Could: Make it match soft_r /soft_rw ?
Suggested change
| def create_hardware_backed_soft_signal( | |
| def create_r_hardware_backed_soft_signal( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}