I19 hutch access device #1098
Merged
I19 hutch access device #1098
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
=======================================
Coverage 97.70% 97.71%
=======================================
Files 163 164 +1
Lines 6680 6690 +10
=======================================
+ Hits 6527 6537 +10
Misses 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
approved these changes
Mar 11, 2025
Comment on lines
+5
to
+8
| class HutchAccessControl(StandardReadable): | ||
| def __init__(self, prefix: str, name: str = "") -> None: | ||
| self.active_hutch = epics_signal_r(str, f"{prefix}EHStatus.VALA") | ||
| super().__init__(name) |
There was a problem hiding this comment.
Could: I think this is actually a good candidate for a declarative device (https://blueskyproject.io/ophyd-async/main/explanations/decisions/0009-procedural-vs-declarative-devices.html#decision)
There was a problem hiding this comment.
On a first try, doing this won't connect giving this error:
raise NotConnected(exceptions)
ophyd_async.core._utils.NotConnected:
access_control: NotConnected: pva://BL19I-OP-STAT-01:PVI
... which makes sense as BL19I-OP-STAT-01:PVI doesn't exist.
I think I'm going to merge this PR as is and try to figure this out in a separate branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1097
Instructions to reviewer on how to test:
dodal connect i19-opticsChecks for reviewer
dodal connect ${BEAMLINE}