Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QBPM as it's not currently used #747

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Remove QBPM as it's not currently used #747

merged 1 commit into from
Aug 15, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #690

Instructions to reviewer on how to test:

  1. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (f8c493e) to head (66bd122).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   94.49%   94.48%   -0.01%     
==========================================
  Files         114      113       -1     
  Lines        4579     4571       -8     
==========================================
- Hits         4327     4319       -8     
  Misses        252      252              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@DominicOram DominicOram merged commit 608d913 into main Aug 15, 2024
24 checks passed
@DominicOram DominicOram deleted the 690_qbpm_1 branch August 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to ophyd-async: qbpm1
2 participants