Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Stage eiger asynchronously in rotation plan #1529

Closed
wants to merge 3 commits into from

Conversation

DominicOram
Copy link
Collaborator

Fixes DiamondLightSource/mx-bluesky#206

Makes use of the start_preparing_data_collection_then_do_plan plan stub we have for setting up the collection that we use in the XRC. begin_sample_environment_setup will ultimately be fully removed by DiamondLightSource/mx-bluesky#205

To test:

  1. Confirm tests pass
  2. Manually confirm grid_detect_then_xray_centre_composite still passes

@olliesilvester
Copy link
Contributor

olliesilvester commented Aug 22, 2024

I will make a PR for this branch which fixes the merge conflict, as well as makes similar changes for the multi_rotation_scan, eg make it also stage the eiger as early as possible

Going to hold off until hyperion mx_bluesky merge is sorted actually

@DominicOram
Copy link
Collaborator Author

Replaced by DiamondLightSource/mx-bluesky#190

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not wait for eiger to stage before snapshots
2 participants