Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Move the basic parameter model components to MXB #1537

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

dperl-dls
Copy link
Collaborator

@dperl-dls dperl-dls commented Aug 19, 2024

For DiamondLightSource/mx-bluesky#162

Moves the parameted model base components to mx-bluesky, re-adds the default values here in hyperion

Link to MXB PR (if required): #163

To test:

  1. Run tests

Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is good as a first pass for getting things generic but I think there's some extra things we should think about (feel free to make new issues or solve here):

  • I dislike that we need to have a subclass to basically just fill in the defaults. I feel like you should be able to do something like the way we fill in the devices using the BlueAPI context where we also fill in these constants from the context (which picks them out the appropriate dodal.beamline)
  • The deploy script currently gives us a dodal deployment in the expected place. Should we now do the same for mx_bluesky?
  • We also need to update our release docs/script to include doing an mx_bluesky release now

@dperl-dls
Copy link
Collaborator Author

dperl-dls commented Aug 20, 2024

@dperl-dls dperl-dls merged commit 942706a into main Aug 20, 2024
8 of 10 checks passed
@dperl-dls dperl-dls deleted the mxb_162_move_params branch August 20, 2024 08:28
dperl-dls added a commit that referenced this pull request Aug 21, 2024
DominicOram pushed a commit that referenced this pull request Aug 21, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…hyperion#1537)

* add mxb workspace

* move parameter components to mx-bluesky

* remove dependency on semver

* update mxb pin
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants