This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Fix to work with updated aperture scatterguard #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dperl-dls
suggested changes
Aug 20, 2024
| ) | ||
| gda_name = aperture_device._loaded_positions[new_selected_aperture].GDA_name |
There was a problem hiding this comment.
should: why make this non-public if you still want to access it here? imo better either leave it public, or provide a method to get the gda name
There was a problem hiding this comment.
Yh, you're right
dperl-dls
approved these changes
Aug 20, 2024
dperl-dls
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Fix to work with updated aperture scatterguard * Don't use private variable on aperture_scatterguard
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…perion#1541) * Fix to work with updated aperture scatterguard * Don't use private variable on aperture_scatterguard * Unpin mx-bluesky
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/dodal#740
Link to dodal PR (if required): DiamondLightSource/dodal#755
To test: