Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tip_offset_um to robot load and centre plan #713

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tip_offset_um to robot load and centre plan #713

wants to merge 1 commit into from

Conversation

olliesilvester
Copy link
Contributor

Fixes #712

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (fd3c0a3) to head (cff8263).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         102      102           
  Lines        6899     6901    +2     
=======================================
+ Hits         5994     5996    +2     
  Misses        905      905
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.88% <ø> (ø)
other 94.17% <100.00%> (+0.01%) ⬆️

rtuck99
rtuck99 requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should have had a test that spotted this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtuck99 rtuck99 rtuck99 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robot load and centre plan should have a tip_offset_um parameter
2 participants
@olliesilvester @rtuck99