Update I24 serial docs #487
Conversation
docs/developer/serial-crystallography-on-i24/how-to/run-a-collection.rst
Outdated
Show resolved
Hide resolved
| **NOTE** As of version ``1.0.0``, the ``Set parameters`` button has been removed and | ||
| the parameters will now be read from the edm and applied to the collection directly | ||
| once the ``Start`` button is pressed. For previous versions however, the button must | ||
| still be pressed before starting the collection. A copy of the parameter file and chip | ||
| map (if applicable) will still be saved in the data directory at collection time. |
There was a problem hiding this comment.
Could: I think docs should usually just reflect the state of things as they currently are rather than as they were. Unless you're worried that the person reading this may be used to the older way of running it?
There was a problem hiding this comment.
In general, I agree with just describing the latest version. In this case, I am a bit worried as scientists and users have been used until now to having to press the set parameters button for the collection to work. I think it may be worth leaving the comment for a bit while the staff gets used to it and then remove it at a later time - hopefully by the beginning of next run...
| - Close to being completed (see issue #44) | ||
|
|
||
| 2. Refactor and fix the logger. | ||
| 3. Use callbacks for file IO eg. to write parameter and map files. |
There was a problem hiding this comment.
And for:
- ispyb deposition
- nexus writing
| * - Use Eiger device and bluesky plans for detector setup | ||
| - Jan. 25 |
There was a problem hiding this comment.
So is this assuming that the FastCS Eiger work is already done and not being done as part of this project? If so we should link the issues and be explicit that it's not under the scope of this
There was a problem hiding this comment.
Yeah, here I was referring only to converting the current set up code into bluesky plans but admittedly I wasn't very clear. I'll rephrase and specify that it's dependent on those issues being completed first
| * - Start moving from edm to web GUI | ||
| - |
There was a problem hiding this comment.
"Start moving" is a bit vague. I would break it into specific things like "move the OAV viewer" and give them dates
| - Reinstate removed code from sacla and move it to bluesky. | ||
| - Add any plans/devices that might be needed for other locations. | ||
|
|
||
| 8. Reinstate full mapping code using bluesky. |
There was a problem hiding this comment.
So this all assumes that we do not change how we run the SSX. Are there any plans for integrating panda and coming up with a more standard PVT way of running the scans?
There was a problem hiding this comment.
Integrating Panda, yes, at least for the fixed target, but I have no idea yet of a possible timeline so I was going to add it at a later time.
There was a problem hiding this comment.
A comment to that affect would be good
…ection.rst Co-authored-by: Dominic Oram <dominic.oram@diamond.ac.uk>
| * - Set up `coniql <https://github.com/DiamondLightSource/coniql>`__ on the beamline | ||
| - Jan. 25 | ||
| - :material-regular:`pending;2em` |
There was a problem hiding this comment.
I believe coniql is now not what we want to use, I'm discussing with people at https://diamondlightsource.slack.com/archives/C06BBH6LX6U/p1727179118445009
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage ? 77.90%
=======================================
Files ? 89
Lines ? 6711
Branches ? 0
=======================================
Hits ? 5228
Misses ? 1483
Partials ? 0
|
No description provided.