Use ophyd_async OAV #594
Merged
Use ophyd_async OAV #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
noemifrisina
requested review from
DominicOram,
rtuck99,
d-perl and
olliesilvester
and removed request for
rtuck99
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
+ Coverage 78.65% 78.67% +0.02%
==========================================
Files 97 97
Lines 6844 6846 +2
==========================================
+ Hits 5383 5386 +3
+ Misses 1461 1460 -1
|
DominicOram
approved these changes
Nov 4, 2024
| assert oav.parameters.micronsPerXPixel is not None | ||
| tip_offset_px = int(tip_offset_microns / oav.parameters.micronsPerXPixel) | ||
| microns_per_pixel_x = yield from bps.rd(oav.microns_per_pixel_x) | ||
| assert microns_per_pixel_x is not None |
There was a problem hiding this comment.
Nit: I don't think it can be None so I would remove this check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs Dodal#857