Clear error 40 before robot load #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 100 100
Lines 6902 6905 +3
=======================================
+ Hits 5996 5999 +3
Misses 906 906
|
olliesilvester
approved these changes
Dec 19, 2024
| @@ -122,6 +122,11 @@ def do_robot_load( | |||
| demand_energy_ev: float | None, | |||
| thawing_time: float, | |||
| ): | |||
| error_code = yield from bps.rd(composite.robot.error_code) | |||
| # Reset robot if light curtains were tripped | |||
tests/unit_tests/hyperion/experiment_plans/test_robot_load_and_change_energy.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #505, where error 40 represents a common error of tripping the light curtains, and thus should be cleared before robot load.
Requires #722