Calibrate panda Y and Z encoder values before panda grid scan #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihab-dls
commented
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
=======================================
Coverage 86.96% 86.97%
=======================================
Files 101 101
Lines 6929 6934 +5
=======================================
+ Hits 6026 6031 +5
Misses 903 903
|
olliesilvester
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Looks good, thanks. Unfortunately, the initial_xyz from flyscan_xray_centre is being removed in #673.
To avoid causing conflicts in that PR, can we instead pass the sample_motors to setup_panda_for_flyscan and then read the initial values here?
shihab-dls
commented
Jan 8, 2025
tests/unit_tests/hyperion/device_setup_plans/test_setup_panda.py
Outdated
Show resolved
Hide resolved
Co-authored-by: olliesilvester <122091460+olliesilvester@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #207.