Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API endpoints to mirror download of Windows Terminal #370

Merged
merged 14 commits into from
Oct 25, 2024

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Oct 14, 2024

Further work to resolve issue #327.

There is a bug with the mintty terminal used by MSYS2 on Windows 10 which prevents textual from working properly (items in the terminal are not clickable via mouse). Windows Terminal can be used as a wrapper around MSYS2 to re-enable proper textual behaviour.

This PR creates the necessary API endpoints in order to download the latest non-draft/prerelease version of Windows Terminal from GitHub.

@tieneupin tieneupin added enhancement New feature or request server Relates to the server component client Relates to the client component labels Oct 14, 2024
@tieneupin tieneupin self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 11.88119% with 89 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (1791847) to head (53adea2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   28.42%   28.47%   +0.04%     
==========================================
  Files          71       71              
  Lines        9537     9651     +114     
  Branches     1286     1298      +12     
==========================================
+ Hits         2711     2748      +37     
- Misses       6730     6804      +74     
- Partials       96       99       +3     

@tieneupin tieneupin changed the title Added API endpoints to mirror download of Window Terminal Added API endpoints to mirror download of Windows Terminal Oct 15, 2024
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
src/murfey/server/api/bootstrap.py Fixed Show fixed Hide fixed
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
src/murfey/server/api/bootstrap.py Dismissed Show dismissed Hide dismissed
@tieneupin tieneupin requested a review from d-j-hatton October 16, 2024 16:41
@tieneupin tieneupin marked this pull request as ready for review October 16, 2024 16:41
@tieneupin tieneupin merged commit 7fca993 into main Oct 25, 2024
17 checks passed
@tieneupin tieneupin deleted the windows-terminal-bootstrapper branch October 25, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Relates to the client component enhancement New feature or request server Relates to the server component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants