Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Commit

Permalink
Minor updates from review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
DominicOram committed Jan 4, 2024
1 parent 0937006 commit 5eb153c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/actions/install_requirements/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ inputs:
install_options:
description: Parameters to pass to pip install
required: true
artifact_name:
description: A user friendly name to give the produced artifacts
required: true
python_version:
description: Python version to install
default: "3.x"
artifact_name:
description: A user friendly name to give the produced artifacts
default: "tests"

runs:
using: composite
Expand All @@ -39,7 +39,7 @@ runs:
shell: bash

- name: Upload lockfiles
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v4.0.0
with:
name: lockfiles-${{ inputs.python_version }}-${{ inputs.artifact_name }}-${{ github.sha }}
path: lockfiles
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
python_version: ${{ matrix.python }}
requirements_file: requirements-test-${{ matrix.os }}-${{ matrix.python }}.txt
install_options: ${{ matrix.install }}
artifact_name: tests

- name: List dependency tree
run: pipdeptree
Expand Down Expand Up @@ -90,7 +91,7 @@ jobs:
pipx run build
- name: Upload sdist and wheel as artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v4.0.0
with:
name: ${{ env.DIST_WHEEL_PATH }}
path: dist
Expand Down Expand Up @@ -134,7 +135,7 @@ jobs:
echo "DIST_LOCKFILE_PATH=lockfiles-${{ env.CONTAINER_PYTHON }}-dist-${{ github.sha }}" >> $GITHUB_ENV
- name: Download wheel and lockfiles
uses: actions/download-artifact@v4
uses: actions/download-artifact@v4.0.0
with:
path: artifacts/

Expand Down Expand Up @@ -211,7 +212,7 @@ jobs:
HAS_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN != '' }}

steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v4.0.0

- name: Fixup blank lockfiles
# Github release artifacts can't be blank
Expand Down

0 comments on commit 5eb153c

Please sign in to comment.