Add cast of message type in command interpreter #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbiemery
changed the title
There was a problem hiding this comment.
Looks good, should wait until #71 is reviewed and merged so we can see the CI passing
Co-authored-by: Garry O'Donnell <garry.o'donnell@diamond.ac.uk>
@callumforrester I also need to sort the command interpreter tests since they now fail. |
abbiemery
force-pushed
the
74_command_interpreter_cast_types
branch
from
24c79a4 to
467bbdf
Compare
Co-authored-by: Callum Forrester <29771545+callumforrester@users.noreply.github.com>
abbiemery
force-pushed
the
74_command_interpreter_cast_types
branch
from
4678280 to
37f711c
Compare
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 65 65
Lines 2084 2085 +1
=======================================
+ Hits 2054 2055 +1
Misses 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. |
callumforrester
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Co-authored-by: Garry O'Donnell garry.o'donnell@diamond.ac.uk Callum Forrester 29771545+callumforrester@users.noreply.github.com