Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.2.0 #1131

Merged
merged 13 commits into from
Jun 24, 2024
Merged

Bump version to 2.2.0 #1131

merged 13 commits into from
Jun 24, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Jun 22, 2024

Next steps:

  • merge to master (I would prefer to use main but only @Diaoul can change that, so let's use master for this release).
  • tag the new version
  • make a release on github and pypi (any idea how?)

There is only one breaking change that is the default encoding is now 'utf-8' instead of the original encoding, so I think it's fine not to bump to version 3.0

@getzze getzze requested a review from ptrcnull June 22, 2024 10:49
@Diaoul
Copy link
Owner

Diaoul commented Jun 22, 2024

merge to master (I would prefer to use main but only @Diaoul can change that, so let's use master for this release).

Let me know where and when I should do this 👍

@getzze
Copy link
Collaborator Author

getzze commented Jun 23, 2024

merge to master (I would prefer to use main but only @Diaoul can change that, so let's use master for this release).

Let me know where and when I should do this 👍

I just pushed a main branch to this repo, you have to make it the default branch in Settings - General - Default Branch. Thanks!

@getzze
Copy link
Collaborator Author

getzze commented Jun 23, 2024

I just saw you updated enzyme, I'll update the version for the dependency then.

Copy link

github-actions bot commented Jun 23, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  subliminal
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@Diaoul
Copy link
Owner

Diaoul commented Jun 23, 2024

Yes, please run some tests in case I broke something 😆

@Diaoul
Copy link
Owner

Diaoul commented Jun 23, 2024

@getzze I did something else which seems more the way to go

  • Changed default branch to develop
  • Renamed develop to main

👉 this way the PRs are all switched against main

@getzze
Copy link
Collaborator Author

getzze commented Jun 23, 2024

Ah cool, that's even better!

Tests are passing with the last enzyme version 🎉

@getzze
Copy link
Collaborator Author

getzze commented Jun 23, 2024

I saw you added a publish github action to enzyme, if we add it to subliminal it will automatically publish the new tagged version to Pypi?

subliminal/cli.py Outdated Show resolved Hide resolved
HISTORY.rst Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ptrcnull
Copy link
Collaborator

one little nitpick that i didn't catch earlier: do we have to print Not using any configuration file. every single time? wouldn't it be better as a debug print?

@getzze
Copy link
Collaborator Author

getzze commented Jun 24, 2024

Yes, I don't like it either.
The problem is that when the config file is parsed, the logger is not set yet therefore the message is "printed".
Another problem I saw is that the two options --debug and --verbose are redundant.

@ptrcnull
Copy link
Collaborator

i'd say redundant options are alright, synonymous flags just make it easier for users to get it first try :P

@Diaoul
Copy link
Owner

Diaoul commented Jun 24, 2024

it will automatically publish the new tagged version to Pypi?

Yes, not tagged though, released and published on GitHub

  1. That usually start with a tag
  2. Then you go do make a new release based on that tag (draft or otherwise), you can decide if beta or not
  3. Only when the release is "published" (i.e. not draft anymore) the workflow will trigger and publish on PyPI 👍

Automation all the way 🤖

@Diaoul
Copy link
Owner

Diaoul commented Jun 24, 2024

I just did all the config so it works as well for Subliminal: there is a PYPI_TOKEN secret and GitHub is a trusted publisher 👍
You can just copy pasted the publish.yaml file (must be this name) 👏

@getzze
Copy link
Collaborator Author

getzze commented Jun 24, 2024

I added the publish.yaml file and a .readthedocs.yaml file also. I will draft a release!

@getzze getzze merged commit f0ee879 into main Jun 24, 2024
20 checks passed
@ptrcnull
Copy link
Collaborator

good job!! thanks everyone, really happy to see a new release ^^

@getzze
Copy link
Collaborator Author

getzze commented Jun 24, 2024

I managed to make the release! Thank you all!
I changed the github action to automatically make a Github release and a Pypi release when a new tag is added.
The documentation in readthedocs was not updated though. If found this gha, but I am not sure it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants