-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2.2.0 #1131
Bump version to 2.2.0 #1131
Conversation
Let me know where and when I should do this 👍 |
I just pushed a |
I just saw you updated |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Yes, please run some tests in case I broke something 😆 |
@getzze I did something else which seems more the way to go
👉 this way the PRs are all switched against |
Ah cool, that's even better! Tests are passing with the last |
I saw you added a |
one little nitpick that i didn't catch earlier: do we have to print |
Yes, I don't like it either. |
i'd say redundant options are alright, synonymous flags just make it easier for users to get it first try :P |
Yes, not tagged though, released and published on GitHub
Automation all the way 🤖 |
I just did all the config so it works as well for Subliminal: there is a PYPI_TOKEN secret and GitHub is a trusted publisher 👍 |
I added the |
good job!! thanks everyone, really happy to see a new release ^^ |
I managed to make the release! Thank you all! |
Next steps:
master
(I would prefer to usemain
but only @Diaoul can change that, so let's usemaster
for this release).There is only one breaking change that is the default encoding is now 'utf-8' instead of the original encoding, so I think it's fine not to bump to version 3.0