Add subtitle language_type and Embedded subtitle subclass #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
getzze
force-pushed
the
add-languagetype-enum
branch
from
2c3914a to
cc9266f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
language_typesummarizes information about the subtitle type: hearing impaired, forced (only foreign parts), normal or unknown.My idea is then to use it to score subtitles with 0 if they do not match the type (asked for HI and got normal), 1 if the type is unknown, and 2 if the type matches (asked for forced subtitle and got it).
The
Embeddedsubclass will be used instead ofvideo.subtitle_languagesto check if subtitles with the given language and language_type were already present.