Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --enable-multithreading flag usage in README #1349

Conversation

rahul-mallick-15
Copy link
Contributor

Issue

$ go run main.go --enable-multithreading --enable-watch
flag provided but not defined: -enable-multithreading

-enable-multithreading flag is removed.
https://github.com/DiceDB/dice/pull/1318/files#diff-fe44f09c4d5977b5f5eaea29170b6a0748819c9d02271746a20d81a5f3efca17
Multithreading is enabled by default

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahul-mallick-15 I see reference of --enable-multithreading flag in docs also, can you please fix that also as part of this PR?

@rahul-mallick-15 rahul-mallick-15 force-pushed the remove_readme_undefined_config_flag branch from 66d7288 to 2f65604 Compare December 3, 2024 14:17
@rahul-mallick-15
Copy link
Contributor Author

@rahul-mallick-15 I see reference of --enable-multithreading flag in docs also, can you please fix that also as part of this PR?

removed references of the flag from docs folder

@rahul-mallick-15
Copy link
Contributor Author

Hi @lucifercr07
Is it possible to run the builds/tests on the pr ?

@lucifercr07
Copy link
Contributor

Hi @lucifercr07 Is it possible to run the builds/tests on the pr ?

Since these are only doc changes tests are not required to be run for these.

@lucifercr07 lucifercr07 merged commit 6aae69b into DiceDB:master Dec 3, 2024
Dev79844 pushed a commit to Dev79844/dice that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants