Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeding Input Optional Labor Configuration Firefox Input Bug #546

Open
JingyuMarcelLee opened this issue Jul 21, 2022 · 4 comments
Open
Labels
bug Something isn't working question Further information is requested UI/UX User Interface / User Experience Improvement

Comments

@JingyuMarcelLee
Copy link
Collaborator

Description of the Issue

When labor is set to "Optional" on the configuration page, the user should be able to either not enter any labor data or enter both labor data. Because the firefox HTML input form allows users to put non-numeric characters even though its type is set to number and simply returns an empty string for the value, there is no way to distinguish between when a user puts invalid input (thus firefox returning "") or user clearing the input after putting something in there (initially it is set to null, then user puts something in it, then deletes it, making it an empty string ""). Thus, whenever the user puts in an invalid input, the feature implemented at #541 stops working.

Steps to Reproduce

  1. Set the configuration to "optional" on the configuration page
  2. Go to the Seeding input and put all the values except labor-related fields to test the submit button.
  3. Put a valid value in one of the fields
    image
  4. Put an invalid value on the other field
  5. Clear the field with a valid value. Now the submit button is highlighted and the field with wrong input is not highlighted

image

Suggested Solution

Need research.

@braughtg braughtg added bug Something isn't working question Further information is requested UI/UX User Interface / User Experience Improvement labels Jul 21, 2022
@Panktivpatel
Copy link

I would like to work on this please!

@braughtg
Copy link
Member

@Panktivpatel Welcome. It would be great to see what you can do with this issue.

Note: If you are in a class that is using the "GitKit" and an assignment asked you to comment on an issue for your course be sure you are using the correct "upstream" for your course. This is the main upstream for FarmData2. We welcome your contributions. But I wanted to be sure this was what you intended.

@Panktivpatel
Copy link

Panktivpatel commented Jan 29, 2024 via email

@braughtg
Copy link
Member

Yes i have been assigned to comment on an issue for my course

Most classes use their own copy of FarmData2 for the course. Your faculty should have given you the URL of the repository for your class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested UI/UX User Interface / User Experience Improvement
Projects
None yet
Development

No branches or pull requests

3 participants