-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropdownWithAllComponent #177
Merged
braughtg
merged 58 commits into
DickinsonCollege:main
from
josieecook:CropAndFieldPickers
Jun 10, 2021
Merged
DropdownWithAllComponent #177
braughtg
merged 58 commits into
DickinsonCollege:main
from
josieecook:CropAndFieldPickers
Jun 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mOS API to choose from.
…and set the default end date to the current day.
… get seeding logs within the dates specified in the start and end date inputs. Also began to fill in table with appropriate variables from the request.
…ay seeding logs between the specified start and end dates. The dates of each log are added to the table, but all of the other details are currently blank.
Merging all current changes for the Tray Seeding Report as of 4/11/2021
Added generate report button and a mock report table
Added All option
Cleaned up code and made sure date/crops appear on the table
Cleaned up generateReport function
Pulled Other Team Members work as of 4/13/2021
Performs an API request for tray seeding logs within the specified dates.
Completed task: start and end dates are used in API request
Task delete
Code clean up
Task-delete (final)
…eport.html and code in fd2_barn_kit.module that created the Tray Seeding Report sub-tab.
Returning main to original upstream code by removing file traySeedingReport.html.
Returning main to the current upstream code.
…into main Merged main with upstream to keep up to date.
… a required dataList property
"Merged main into feature branch to access new files that allow component testing"
…armData2 into CropAndFieldPickers
…ress test for ex1.html to test the new dropdown menu
Please create a separate PR for the DatePicker rather than adding it to this PR. |
…s additions of DropdownWithAllComponent
braughtg
requested changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. There are a few comments in the review for you to touch up and one to investigate.
farmdata2_modules/fd2_tabs/resources/dropdownWithAllComponent.js
Outdated
Show resolved
Hide resolved
…ent so that it will reset to have no input if something is typed in that isn't in the menu.
braughtg
approved these changes
Jun 10, 2021
braughtg
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Finished a functional dropdownWithAll component and implemented it in the ex1.html file
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.