Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownWithAllComponent #177

Merged
merged 58 commits into from
Jun 10, 2021

Conversation

josieecook
Copy link
Contributor

Pull Request Description

Finished a functional dropdownWithAll component and implemented it in the ex1.html file


Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

Diego2214 and others added 30 commits April 5, 2021 16:01
…and set the default end date to the current day.
… get seeding logs within the dates specified in the start and end date inputs. Also began to fill in table with appropriate variables from the request.
…ay seeding logs between the specified start and end dates. The dates of each log are added to the table, but all of the other details are currently blank.
Merging all current changes for the Tray Seeding Report as of 4/11/2021
Added generate report button and a mock report table
Cleaned up code and made sure date/crops appear on the table
Cleaned up generateReport function
Pulled Other Team Members work as of 4/13/2021
Performs an API request for tray seeding logs within the specified dates.
Completed task: start and end dates are used in API request
ShannonLoughin and others added 22 commits April 20, 2021 22:27
…eport.html and code in fd2_barn_kit.module that created the Tray Seeding Report sub-tab.
Returning main to original upstream code by removing file traySeedingReport.html.
…into main

Merged main with upstream to keep up to date.
"Merged main into feature branch to access new files that allow component testing"
…ress test for ex1.html to test the new dropdown menu
@braughtg
Copy link
Member

braughtg commented Jun 9, 2021

Please create a separate PR for the DatePicker rather than adding it to this PR.

Copy link
Member

@braughtg braughtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. There are a few comments in the review for you to touch up and one to investigate.

farmdata2_modules/fd2_tabs/fd2_example/ex1.html Outdated Show resolved Hide resolved
farmdata2_modules/fd2_tabs/fd2_example/fd2_example.info Outdated Show resolved Hide resolved
…ent so that it will reset to have no input if something is typed in that isn't in the menu.
@braughtg braughtg marked this pull request as ready for review June 10, 2021 17:01
@braughtg braughtg merged commit a3d165f into DickinsonCollege:main Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants