-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date and Date Range Selection Components #178
Closed
josieecook
wants to merge
94
commits into
DickinsonCollege:main
from
josieecook:DateAndDateRangeSelection
Closed
Date and Date Range Selection Components #178
josieecook
wants to merge
94
commits into
DickinsonCollege:main
from
josieecook:DateAndDateRangeSelection
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mOS API to choose from.
…and set the default end date to the current day.
… get seeding logs within the dates specified in the start and end date inputs. Also began to fill in table with appropriate variables from the request.
…ay seeding logs between the specified start and end dates. The dates of each log are added to the table, but all of the other details are currently blank.
Merging all current changes for the Tray Seeding Report as of 4/11/2021
Added generate report button and a mock report table
Added All option
Cleaned up code and made sure date/crops appear on the table
Cleaned up generateReport function
Pulled Other Team Members work as of 4/13/2021
Performs an API request for tray seeding logs within the specified dates.
Completed task: start and end dates are used in API request
Task delete
Code clean up
added table component and test file for table component
The cypress tests included that the tbale exist, all headers appear as they should, all data apears in the table, can use the edit and save buttons to make changes to the tabl, and can delete a row from the table. Emits delete and save events tests are not yet completed
Table component
…onents so that they are functional within both farmdata2 and the cypress tests
Date and date range selection - Import Update
…h the new ones used in the date selection components
Crop and field pickers
Table component
Date selection components
Is this PR superseded by #180? If so please close this one. Thanks. |
RolandLocke
pushed a commit
to RolandLocke-s-FD2-Org/FarmData2
that referenced
this pull request
Jul 15, 2023
* created file to test seeding input type defaults * Filled out before each * Our team's test shows up in correct folder so we can run in Cypress * Added test to check if the Tray element is enabled * Added test to check if the Direct element is enabled * tested that neither the tray nor the direct element is selected * tested whether the message to prompt tray/direct element selection is visible * Tested that the form elements for Tray and Direct are not visible * Finished testing visibility of form elements - had to add one more * Deleted unnecessary (duplicate) test file from field kit * Adjusted the comment in the describe and added a descriptive comment at the top of the file. * merged second and third individual test into one test * changed data-cy attribute of message to prompt selection of tray or direct element --------- Co-authored-by: Alexandrialexie <brownale@dickinson.edu> Co-authored-by: andrewscheiner53 <scheinea@dickinson.edu>
braughtg
pushed a commit
that referenced
this pull request
Jul 29, 2023
* created file to test seeding input type defaults * Filled out before each * Our team's test shows up in correct folder so we can run in Cypress * Added test to check if the Tray element is enabled * Added test to check if the Direct element is enabled * tested that neither the tray nor the direct element is selected * tested whether the message to prompt tray/direct element selection is visible * Tested that the form elements for Tray and Direct are not visible * Finished testing visibility of form elements - had to add one more * Deleted unnecessary (duplicate) test file from field kit * Adjusted the comment in the describe and added a descriptive comment at the top of the file. * merged second and third individual test into one test * changed data-cy attribute of message to prompt selection of tray or direct element Co-authored-by: Alexandrialexie <brownale@dickinson.edu> Co-authored-by: andrewscheiner53 <scheinea@dickinson.edu> --------- __Pull Request Description__ Pull Request Description This pull request was orignially created on [FD2School-FarmData2](https://github.com/DickinsonCollege/FD2School-FarmData2). Link to the original pull request: https://github.com/DickinsonCollege/FD2School-FarmData2/pull/178 Partially Addresses #662 --- __Licensing Certification__ FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request __I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)__ for its contents. Co-authored-by: pranavm2109 <98339495+pranavm2109@users.noreply.github.com> Co-authored-by: Alexandrialexie <brownale@dickinson.edu> Co-authored-by: andrewscheiner53 <scheinea@dickinson.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
At the moment, cypress tests will run and pass but it will not work within farm data because of the double definition of DateSelectionComponent.
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.