Updated comment #288
Merged
Updated comment #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR seems to have adjusted the formatting so that it appears that nearly every line in the file has been changed. Please update the PR so that the changes are limited to only the line with the comment. |
|
Sure. Worked with Visual Studio with Prettier. Not sure what happened, but
I’ll fix it.
בתאריך יום ב׳, 4 באוק׳ 2021 ב-20:10 מאת Grant Braught <
***@***.***>:
… Your PR seems to have adjusted the formatting so that it appears that
nearly every line in the file has been changed. Please update the PR so
that the changes are limited to only the line with the comment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALDZMGQTTGJPC76NC7CCFELUFHNX5ANCNFSM5FJSVUWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I suspect that the formatting of our code is just different than what prettier did. Better code formatting standards is on our to-do list. |
|
After fixing this issue I’ll be happy to assist in that. Apart from being a
programmer in the last 6 years, I’m an agronomist and a water engineer by
the way.
בתאריך יום ב׳, 4 באוק׳ 2021 ב-20:42 מאת Grant Braught <
***@***.***>:
… I suspect that the formatting of our code is just different than what
prettier did. Better code formatting standards is on our to-do list.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALDZMGU74VN2ELWHBB4VSZ3UFHRO7ANCNFSM5FJSVUWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Argronomist and programmer - thats not a common combination - but seems like an ideal fit for this type of project! Help with the code formatting guides would be great. Check out Issue #79, it gives just a little information and is a place holder there so I didn't lose track of it. If you want to further discuss code formatting we can do so there. |
|
Closes #287 |
braughtg
pushed a commit
that referenced
this pull request
Jul 29, 2023
…l/228 This pull request was orignially created on [FD2School-FarmData2](https://github.com/DickinsonCollege/FD2School-FarmData2). Link to the original pull request: [#288](https://github.com/DickinsonCollege/FD2School-FarmData2/pull/228) Authors of the original Commit are listed here as co-Authors: Co-authored-by: jamesng5 <nguyenja@dickinson.edu> Co-authored-by: vuphuongha <havu0910@gmail.com> Co-authored-by: tainguyen103 <tainguyen103200@gmail.com> Partially Addresses #662 --- __Licensing Certification__ FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request __I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)__ for its contents. Co-authored-by: James Ng <98336522+jamesng5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.