Repairing Updating Rows from within the Seeding Report #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated. 1. Cypress tests need to be added to more rigorously test this change
1. There's a bug where changing area and quantity is causing a 422 status code. 2. The Cypress test seems to not be updating the values. This has to seriosuly be investigated.
1. Fixed a bug where updating the quantity and the area at the same time would result in a 422 status code from the server. 2. FIxed a bug where editing date, crop, area, comments, or user alongside any of the quantities would not update the log on the frontend with the appropriate information. 3. Added the IDToAreaMap in order to fix an issue where area would be empty inside the report page when updating it alongside other quantities. 4. Still need to update/add Cypress test(s) to test these changes
1. Made sure that the log inside of the report is accurate to the backend
1. Unfinished currently because we have to create a direct seeding log and an asset for testing purposes and the asset is producing an error.
|
This PR is ready to be reviewed. I decided not to implement the createRecord() piece into the tests because I intend to write an issue to changes all logs that are being created the current way to use createRecord() instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #544. This pull request aims to fix the
updateRows()method located inside of the Seeding Report html page. These changes are accompanied by a more rigorous testing case for the editing functionality of the table so that future devs realize that changing the headers to the table breaks the function responsible for updating the rows.This PR is NOT ready to be merged yet
Things that need to be completed prior to a proper review for merging:
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.