Updating Export Button Functionality #591
Conversation
1. Updated the exportCSV() function to only print rows whose IDs can be found in the indexesToAction array. 2. Changes one of the cleanHTML lines to replace new lines with just blank spaces instead of dashes. 3. Made sure the button is disabled when nothing is selected just like the delete button and custom buttons.
|
@braughtg Do you believe all the buttons should reset the |
This sounds like a good idea. It is a clear rule on how they should behave and should be intuitable by the user. If it turns out to be inconvenient and we hear feedback otherwise from end users, we can adapt. So move forward under this assumption. |
|
Do you have any idea what may be causing this [unrelated bug] in the Seeding Report? The logs never finish generating and the report tables as the bottom never appear as a result. @braughtg It doesn't do this on my laptop. I tried rebuilding the database and that also doesn't work. It seems to be a bug only I'm running into even though my main is exactly like the upstream/main. |
|
Maybe a browser specific issue?
On Dec 13, 2022, at 10:40, Chris ***@***.***> wrote:
|
Seems to be, it works just fine on Chromium based browsers (tested on Opera GX, Chrome, and Edge). |
|
Could you pull this PR and recreate these steps on your machine? @braughtg
I'd like to know if my machine is being buggy or if the export functionality isn't being consistent across browsers. If the latter is the case, this is really concerning because Chromium browsers do not play nice with Vue dev tools which makes it challenging to debug Vue code. |
This worked fine for me in Chrome and in Firefox on MacOS, and in Firefox in the Dev Container. |
I saw the same behavior in both Chrome and Firefox on MacOS. The CSV terminated with the 2020-06-26 row for Cabbage when used from both browsers. So neither browser produced the full report. In Firefox, in the Dev Container I'm getting the abbreviated columns (i.e. mobile view?) where there is no row select check box and thus no way to select all of the rows or to delete or edit rows. This happened no matter what the size of the window was, so this may be a separate issue. But, when I clicked the export button, it exported the whole table. But with fewer columns per row, becuase that is what was being displayed. (This is now its own issue #592 ) So, the issue with the export being cut off seems like it might be due to be a limit on the size of the data that the CSV library you are using. Is that possible? |
It seems like this might be it. I uninstalled and reinstalled FireFox on my machine and that seemed to fix the problem I was having before. Now FireFox is behaving in-line with the Chromium based browsers where the export only exports up to a certain number of rows. In regards to the mobile view appearing in the dev container, I did not experience similar issues. I got full columns with nothing excluded and had the checkboxes present as well. That should be something we keep an eye out for in case it's not machine dependent and is an independent bug.
|
1. Changed the way the csv file object was created. Apparently using the URI encoder limits the amound of data that can be downloaded into the csv. Using a blob object seems to solve this issue. 2. Made it so that if the delete or custom buttons are not present, the select a row feature still appears if the dev allows for csv buttons. This did not exist before, probably an oversight due to export functionality being considered after the fact. CustomTable Unit Test Changes 1. Updated the unit test to verify that the export button is unclickable when no rows are selected. Made sure downloading one row is assured. Made sure downloading multiple rows is assured.
1. Added the ' -' back to replacing new lines among other things
…ta-2-Dev-Team-2022/FarmData2 into updateExportFunctionality
Pull Request Description
Closes #589 and Closes #571 . This PR aims to update some functionality of the export button that were left out when the CustomTableComponent was being reworked. This includes updating its behavior to be consistent with the behavior of other buttons that are part of the table. Additionally, this PR addresses a bug where the export button leaves behind some
-in the comments field.This PR is
notready to be merged into upstream/mainBelow are some things that need to be completed before this PR is ready for review:
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.