Backend and Frontend Fixes for Transplanting Report #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Simplified some existing code 2. Removed the ability to edit bed feet because the data structure doesn't have that quantity in its data 3. Added the ability to edit row/bed because the data structure does have this in its qunatity data 4. Backend now supports quantity changes but fails to update correctly when a quantity and area change is made at the same time. Database Rebuilt 1. Rebuilt for testing purposes (this is inefficient, and I'll have to think of another way of fixing these logs (maybe make dummy logs? I can't though because no transplanting form exists...)
1. Removed a space between a function header and the body of the function. 2. Was closely looking at the CustomTableComponent because at some point I must've changed the emit event name for the cancellation of an edit without realizing it and updating it for the report pages. Seeding Report Page Changes 1. Changes the receiver for the cancellation of a cancel button event. This fixed a bug where editing once permanently disabled the filters. Transplatning Report Page Changes 1. Changes the receiver for the cancellation of a cancel button event. This fixed a bug where editing once permanently disabled the filters. 2. Updated the updateRow function to properly update the backend and frontend.
FutzMonitor
changed the title
|
I don't think we want the zipped database ( |
braughtg
reviewed
Jan 17, 2023
|
Those changes should be gone from this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #562. This issue makes some changes to the
updateRowfunction located in the Transplanting Report HTML file [here]. These changes are not accompanied by any Cypress e2e testing as that is a separate issue to be addressed in issue #578. As a result, these changes have been tested by sight using Hoppscotch.Additionally, this PR makes a quick fix of the filters for both the Seeding Report and Transplanting Report where editing once would permanently disable the filters until the page was refreshed because the name of the edit cancellation event was changed and the pages were not updated accordingly to reflect this change.
This PR also brings up the topic of #585 (and #466) of what should be edit-able. I disabled the ability to edit
bed feetin the Transplanting Report because transplanting logs don't have quantity data forbed feetbut also enabled the ability to editrow/bedbecause that does exist in the logs' quantity data. However, should users be allowed to edit that data? This is beyond the scope of this PR but wanted to quickly mention this quick thought that occurred to me whilst making this fix.Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.