Don't check declared vars in the unused-variable-rule

fix palantir#190
DickvdBrink · May 14, 2015 · 5ed5eb6 · 5ed5eb6
1 parent b08678f
commit 5ed5eb6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/rules/noUnusedVariableRule.ts b/src/rules/noUnusedVariableRule.ts
@@ -93,9 +93,10 @@ class NoUnusedVariablesWalker extends Lint.RuleWalker {
         this.skipParameterDeclaration = false;
     }
 
-    // skip exported variables
+    // skip exported and declared variables
     public visitVariableStatement(node: ts.VariableStatement): void {
-        if (this.hasModifier(node.modifiers, ts.SyntaxKind.ExportKeyword)) {
+        if (this.hasModifier(node.modifiers, ts.SyntaxKind.ExportKeyword)
+            || this.hasModifier(node.modifiers, ts.SyntaxKind.DeclareKeyword)) {
             this.skipVariableDeclaration = true;
         }
 

diff --git a/test/files/rules/nounusedvariable-var.test.ts b/test/files/rules/nounusedvariable-var.test.ts
@@ -16,3 +16,5 @@ try {
 } catch (e) {
   // e is unused but that's still ok
 }
+
+declare var tmp: any;