generic routing handler #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renejahn
requested changes
Jul 18, 2022
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/util/RestTemplateProxyCustomizer.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/util/RestTemplateProxyCustomizer.java
Outdated
Show resolved
Hide resolved
soeren-rtgr-tk
requested changes
Jul 18, 2022
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/routing/RoutingHandler.java
Outdated
Show resolved
Hide resolved
soeren-rtgr-tk
requested changes
Jul 18, 2022
src/main/java/de/tk/opensource/privacyproxy/util/ProxyHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/config/proxy/HttpProxyConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/util/ProxyHelper.java
Outdated
Show resolved
Hide resolved
renejahn
requested changes
Jul 20, 2022
src/main/java/de/tk/opensource/privacyproxy/util/ProxyHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tk/opensource/privacyproxy/util/RestTemplateProxyCustomizer.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
renejahn
approved these changes
Jul 22, 2022
soeren-rtgr-tk
approved these changes
Jul 22, 2022
| routePlanner = | ||
| new DefaultProxyRoutePlanner(proxy) { | ||
| new DefaultProxyRoutePlanner(httpHost) { |
There was a problem hiding this comment.
Könnte als Klasse ausgelagert werden. Würde ich schöner finden
There was a problem hiding this comment.
Schiebe ich in einem zweiten PR nach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to handle get and post right