Avoid reservation if the User is not logged. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reserve a concert' if user is not logged
…id problems when accesing state
Diegogagan2587
added
bug
Diegogagan2587
changed the title
Diegogagan2587
changed the title
…eserve if user not logged
danifromecuador
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Your implemented changes will contribute to improving the UX by automatically redirecting to the login page
- All tests are passing
- Descriptive PR
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
You can also consider:
- [OPTIONAL] None
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @danifromecuador
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement suggested changes in #60
Implemented Changes:
Reserve buttonredirects to the login page if the user is not logged in and updates user message toPlease login before reservesetUserMessagereducerLogin Pageshows the alert suggesting the user to log in before creating a reservation.reserve button, this action will redirect you to the Login page.Please login to reserve a concertalert.Please login to reserve a concertAlert is being rendered.