Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/login style update #97

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Conversation

Diegogagan2587
Copy link
Owner

Implemented Changes

Style

  • Update sizes and add a background image to enhance and match the login page as much as possible with the original design.

image
image

@Diegogagan2587 Diegogagan2587 self-assigned this May 29, 2024
@Diegogagan2587 Diegogagan2587 added the enhancement New feature or request label May 29, 2024
Copy link
Collaborator

@danifromecuador danifromecuador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Diegogagan2587

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Your implemented changes will contribute to improve the app overall desing ✅

chuck-norris-thumbs-up

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

You can also consider:

  • [OPTIONAL] Please consider adding the same style of login page to signup page
    image

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @danifromecuador

@Diegogagan2587 Diegogagan2587 merged commit c2f6d5d into development Jun 6, 2024
3 checks passed
@Diegogagan2587 Diegogagan2587 deleted the feat/login-style-update branch June 6, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants