Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pin this Category" in wrong #1006

Closed
yushizui opened this issue Jun 29, 2024 · 4 comments
Closed

"Pin this Category" in wrong #1006

yushizui opened this issue Jun 29, 2024 · 4 comments

Comments

@yushizui
Copy link

LRR Version and OS
0.9.1 docker
Bug Details
#689 There seems to be an error in the category sorting after the update. It does not seem to be sorted according to the alphabetical order mentioned above, and the "Pin this Category" seems to be invalid. I don’t know if it has something to do with the use of Chinese.

@yushizui
Copy link
Author

I just created a new docker and tried it, I think it's because the existing sorting method is not compatible with other language.

Would you consider compatibility with other languages,Seems like it could be solved by adding a letter to the front as well,I have quite a few Categories. If you consider compatibility, I won’t modify them for the time being.

@Difegue
Copy link
Owner

Difegue commented Jun 30, 2024

The sorting just relied on basic javascript comparison -- I've pushed a change to rely on localeCompare instead which might improve the situation for non-english languages.

No idea why pinning wouldn't work though -- Feel free to reopen this if you still have issues

@Difegue Difegue closed this as completed Jun 30, 2024
@yushizui
Copy link
Author

yushizui commented Jul 1, 2024

The sorting just relied on basic javascript comparison -- I've pushed a change to rely on localeCompare instead which might improve the situation for non-english languages.

No idea why pinning wouldn't work though -- Feel free to reopen this if you still have issues

pinning will only fail if other language is used.

@Nuo-Mituan
Copy link

You can add this icon before the label name to fix the label in the first place
📌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants