Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag edit features broken on mobile #1055

Closed
alethiophile opened this issue Aug 16, 2024 · 0 comments · Fixed by #1062
Closed

Tag edit features broken on mobile #1055

alethiophile opened this issue Aug 16, 2024 · 0 comments · Fixed by #1062

Comments

@alethiophile
Copy link
Contributor

LRR Version and OS
dev branch, Linux

Bug Details
When using a mobile browser, you can't use a plugin to import metadata. Instead, an error appears talking about Edit.tagInput.

In edit.js, the tagger instance assigned to Edit.tagInput is not initialized if the user is on a mobile browser. However, later code still depends on this object. In particular, the getTags code that calls a server-side plugin unconditionally uses tagInput.add_tag to add the new tags to the field. This fails on mobile.

I assume that pasting tags into the field is also broken, since it depends on the same function. The obvious fix is simply to detect whether the tagInput object is initialized, and if not then edit the textarea directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant