Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrows in web reader DO NOT work in zh locale #1145

Closed
PalonCheng opened this issue Dec 30, 2024 · 2 comments
Closed

Arrows in web reader DO NOT work in zh locale #1145

PalonCheng opened this issue Dec 30, 2024 · 2 comments

Comments

@PalonCheng
Copy link

LRR Version and OS
docker difegue/lanraragi:latest v.0.9.30

Bug Details
图片
the arrows DO NOT work in zh locale

after rm the zh.po and restart the container
they do work in en locale

Matching Logs
In debug mode , there is no error

@PalonCheng
Copy link
Author

PalonCheng commented Dec 30, 2024

I modify the zh.po
revert the translations for outer-left left right outer-right
it seems like this
"
msgid "Display all images in a vertical view in the same page."
msgstr "在同一页面中以垂直视图显示所有图片。"

msgid "outer-left"
msgstr "outer-left"

msgid "left"
msgstr "left"

msgid "right"
msgstr "right"

msgid "outer-right"
msgstr "outer-right"

msgid "Reader Settings"
msgstr "阅读器设置"
"

and now the arrows work!

maybe these words are not necessary to translate
they do not show in the browser

and maybe it is handled in /public/js/reader.js (I just find the word "outer-right")
from line 789 Reader.handlePaginator
for the several case
(
They are fixed in the case
791 case "outer-left":
and follow 3 cases
)

@PalonCheng PalonCheng changed the title Arror DO NOT work in zh locale Arrows in web reader DO NOT work in zh locale Dec 30, 2024
@Difegue
Copy link
Owner

Difegue commented Dec 31, 2024

Yup, that's the issue. Thanks for sleuthing on this!

@Difegue Difegue closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants