Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a Tankoubon API endpoint does not delete the summary and tags values #1156

Closed
junpet opened this issue Jan 4, 2025 · 1 comment · Fixed by #1157
Closed

Update a Tankoubon API endpoint does not delete the summary and tags values #1156

junpet opened this issue Jan 4, 2025 · 1 comment · Fixed by #1157

Comments

@junpet
Copy link

junpet commented Jan 4, 2025

LRR Version and OS
LANraragi 0.9.3 - Law (Earthlings on Fire)
Debian GNU/Linux bookworm 12.8 x86_64
Docker version 27.4.1, build b9d17ea

Bug Details
Update a Tankoubon API endpoint (PUT http://lrr.tvc-16.science/api/tankoubons/:id) does not delete the summary and tags values. I tried with empty string

{
  "metadata": {
    "summary": "",
    "tags": ""
  }
}

and null

{
  "metadata": {
    "summary": null,
    "tags": null
  }
}

but it does not delete the previous values. I tried updating only one of the metadata, but the result is the same.

@EfronC
Copy link
Contributor

EfronC commented Jan 6, 2025

Yes, the issue is that I didn't expect to erase the summary and tags, so the check I use to verify that the field is defined also skips it if is "". Will fix it.

EfronC added a commit to EfronC/LANraragi that referenced this issue Jan 6, 2025
@EfronC EfronC mentioned this issue Jan 6, 2025
@Difegue Difegue linked a pull request Jan 10, 2025 that will close this issue
Difegue pushed a commit that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants