Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-H Plugin #28

Closed
ghost opened this issue Feb 28, 2018 · 3 comments
Closed

E-H Plugin #28

ghost opened this issue Feb 28, 2018 · 3 comments
Labels
plugin
Milestone
0.5.4

Comments

@ghost
Copy link

ghost commented Feb 28, 2018

Hey.
I'm guessing standard metadata fetching is only using the title and only the first result of multiple hits is requested? I'm asking because most of my tags are from french and russian galleries. English and Japanese galleries tend to be the most extensively tagged and accurate. So I was wondering whether you could add the tags scraped from file during query like so
parody:"fate grand order$" language:english$ "Blah Blah(Title)"
@Difegue
Copy link
Owner

Difegue commented Feb 28, 2018

I'm guessing standard metadata fetching is only using the title and only the first result of multiple hits is requested?

Yeah that's basically how it works - I used to add the author into the mix but it wasn't very helpful.

I'll add language tags into the search when they are present - This should give more precise results.

Difegue added a commit that referenced this issue Mar 2, 2018
@Difegue
EH Plugin now adds language tag if present. (#28)
d55e956 
+ Fixed missing fonts in themes
+ Improved Reader when encountering corrupt images
+ Fixed potential HTTPS errors in nHentai by enforcing IO::Socket::SSL 2.056
@Difegue Difegue closed this as completed Mar 2, 2018
@ghost
Copy link
Author

ghost commented Mar 5, 2018

Speaking of, could you add an option to specify preferred language? Seeing as japanese galleries do not specify language in their titles.

@Difegue Difegue reopened this Mar 6, 2018
@Difegue Difegue added this to the 0.5.1 milestone Mar 6, 2018
@Difegue Difegue added the plugin label Mar 11, 2018
@Difegue
Copy link
Owner

Difegue commented Mar 21, 2018

Done in 1d66636 - Although this sacrifices the option to disable reverse image search due to the way plugin arguments currently work.

Will open another issue for that.

@Difegue Difegue closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin
Projects
None yet
Milestone
0.5.4
Development

No branches or pull requests
1 participant
@Difegue