-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve HDoujin info.txt parsing #1053
Conversation
Parse tags from additional fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall - I think the tests should be updated to reflect the new summary/description parsing here. Thanks!
Filter out irrelevant fields and support more JSON configurations
Thank you for the feedback! I updated the JSON parser to read the summary and make it more consistent with the output from the TXT file parser. It was adding all the fields as tags (including titles and URLs), but I've limited it to a more relevant subset. I also updated it to work with different JSON configurations (the outer
Correct me if I'm wrong, but it doesn't look like there are any tests for this format right now. I could possibly add some. |
Thanks! The JSON parser was a pretty old bit of code so I'm not surprised if it was worse than the txt version. |
Congratulations @HDoujinDownloader, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm0063ggy18850clbr48u3ufu This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Thanks squiddy for working on this, I actually enjoyed that it would pull URLs since in mihon/tachi i could search nhentai codes and it would resolve because the url is part of the tags and it was useful at least for me. when i saw this PR i was hoping that it would fix the ability for this plugin to pull the title too because right now im using a secondary plugin just to pull title information from the metadata file. |
@Boontato Oh! I didn't even notice plugins could specify a gallery title. I'll get that fixed and submit a new PR in a bit. @Difegue What's your take on having URLs in the tags (e.g. |
You should use |
Yes I have been using tag rules to convert url namespace to source namespaces. mihon also allowed specifying which namespace to use to pull the url too. |
Currently, tags are only extracted from the
TAGS
field for HDoujin's info.txt files. I've updated the plugin to extract tags from other fields as well (artist, series, language, parody, etc.), and namespace them accordingly.