Double page laod speedup & Fullscreen & Mouse wheel move #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need canvas nomore... canvas draw is so slow and heavy
we don't need canvas nomore... canvas draw is so slow and heavy
now when popup is open page don't change. and some position issue fix
i add some fullscreen on pc web and new event key press F(fullscreen toggle) and when u active fullscreen u can use a mouse wheel to move. enjoy :)
djacks6278
changed the title
Difegue
requested changes
Apr 4, 2022
There was a problem hiding this comment.
👋 Thanks a lot for willing to contribute with Reader improvements! 🙏
As you've probably seen it's a bit complex, so I'll gladly accept the work.
Most of the changes here are good (I especially appreciate fullscreen mode!), but I tested the PR and found a few issues that have to be fixed before I can merge this.
|
@Difegue i don't know how close the your review so u need check again! |
Difegue
requested changes
Apr 5, 2022
|
i fixed all review well i'm too late sorry about that |
Difegue
approved these changes
Apr 9, 2022
|
Yup, looks great! 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canvas draw is so slow and heavy when load high resolution image...
so change this code like single page view
no more need to draw in canvas
and i change imagemap to jquery
outer-left, outer-right is now work perfectly