-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing timstamp,category,uploader tags to the eze plugin #606
Conversation
…ugin BREAK CHANGES: the parameters for tags_from_eze_json has changed to ($save_title, $origin_title, $additional_tags) * Add support for date_uploaded and category tags from eze plugin * get category from gallery_info, fallback to gallery_info_full * change date_uploaded to timestamp add uploader tag for eze this make the eze tag more E-Hentai plugin style * add EH-plugin like options for eze test cases are modified for cross-condition tests * better description * update basic tags of eze for untagged-archives * Update miscellaneous-other-api.md * update version number
The test failed... It runs perfectly on my dev environment. How about adding it? Or just give up converting time from gallery_info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few remarks but this is overall good -- There's no real breaking changes since tags_from_eze_json
is an internal function only called by the eze plugin itself. 👍
This comment was marked as resolved.
This comment was marked as resolved.
That one's good to go as well 👏 Thanks! |
fixed #584
BREAK CHANGES: the parameters for tags_from_eze_json has changed to ($save_title, $origin_title, $additional_tags)
Add support for date_uploaded and category tags from eze plugin
get category from gallery_info, fallback to gallery_info_full
change date_uploaded to timestamp add uploader tag for eze
this make the eze tag more E-Hentai plugin style
add EH-plugin like options for eze
test cases are modified for cross-condition tests
better description
update basic tags of eze for untagged-archives
Update miscellaneous-other-api.md
update version number