Filter more credit pages & move covers to start #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some RedLantern credit pages were just "Artist_Info" and not "Artist_Info_Store_Links"
Exclude Back, End, Rear from results
|
This still needs to be improved to reduce false positives. The search for cover pages now excludes filenames with "back", "rear" and "end". But I need to make it only match "cover" as a whole word, or a word ending and or starting with numbers/special characters. To avoid it matching e.g "discover". I'm not very good at regex, help would be appreciated. Otherwise, I can simplify this PR to just filter the most common credit pages only e.g NHNL and Red Lanterns. |
Difegue
requested changes
Jan 31, 2023
Co-authored-by: Difegue <8237712+Difegue@users.noreply.github.com>
Co-authored-by: Difegue <8237712+Difegue@users.noreply.github.com>
Difegue
approved these changes
Feb 5, 2023
|
I didn't test all possible permutations but this seems solid enough, let's get this merged. 👍 Thanks for taking the time with this! Here's a Holobyte. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of scanlators who name their files in a way that puts the credit/translation note pages at the start of a gallery. This PR filters them so they are at the end of a gallery instead.
artist_info - [RedLantern]
9999nhnl - [nhnl]
end_card_save_file - [LunaticSeibah]
9999999* - [MegaFaget]
bumper - [cowboy]
ramble - [degenerate]
And also filters out filenames ending in "note." or "notes." with the period being the file extension, this aims to remove commonly used names for translation notes. I also added a filter to locate filenames ending with "cover." and set them to be the first images in a gallery, so we more reliably find front covers & correct thumbnails for galleries.
I tried to use stricter regex for the commonly used names/characters to avoid false positives, but more may be required.