-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chaika plugin adds more tags #749
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e49dd96
Chaika plugin adds more tags
kagoromo b4de971
Avoid adding empty tags
kagoromo e60c75e
Fix feedbacks
kagoromo 871f5d4
Test failing due to logger, not sure why
kagoromo 4f8a4e0
Fix test
kagoromo 369d118
SHA1 JSON is an array
kagoromo 82a5015
Adjust test data
kagoromo db23e95
Fix undef warning
kagoromo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,32 @@ | ||
[{ | ||
"category": "Manga", | ||
"download": "/archive/27240/download/", | ||
"expunged": false, | ||
"filecount": 19, | ||
"filesize": 63418139, | ||
"fjord": true, | ||
"gallery": 23532, | ||
"posted": 1521353952, | ||
"rating": 4.45, | ||
"tags": [ | ||
"female:sole_female", | ||
"male:sole_male", | ||
"artist:kemuri_haku", | ||
"full_censorship", | ||
"male:shotacon", | ||
"female:defloration", | ||
"female:nakadashi", | ||
"female:big_breasts", | ||
"language:translated", | ||
"language:english" | ||
], | ||
"title": "[Kemuri Haku] Zettai Seikou Keikaku | Absolute Intercourse Plan (COMIC Shitsurakuten 2016-03) [English] [Redlantern]", | ||
"title_jpn": "[煙ハク] 絶対セイコウ計画 (COMIC 失楽天 2016年3月号) [英訳]", | ||
"uploader": "dankestdungeon" | ||
}] | ||
[ | ||
{ | ||
"category": "Manga", | ||
"download": "/archive/27240/download/", | ||
"expunged": false, | ||
"filecount": 19, | ||
"filesize": 63418139, | ||
"fjord": true, | ||
"gallery": 23532, | ||
"id": 27240, | ||
"posted": 1521357552, | ||
"rating": 4.49, | ||
"tags": [ | ||
"full_censorship", | ||
"female:sole_female", | ||
"male:sole_male", | ||
"artist:kemuri_haku", | ||
"female:tall_girl", | ||
"female:cunnilingus", | ||
"male:shotacon", | ||
"female:defloration", | ||
"female:nakadashi", | ||
"female:x-ray", | ||
"female:big_breasts", | ||
"language:translated", | ||
"language:english" | ||
], | ||
"title": "[Kemuri Haku] Zettai Seikou Keikaku | Absolute Intercourse Plan (COMIC Shitsurakuten 2016-03) [English] [Redlantern]", | ||
"title_jpn": "[煙ハク] 絶対セイコウ計画 (COMIC 失楽天 2016年3月号) [英訳]", | ||
"uploader": "dankestdungeon" | ||
} | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of carrying the
$addsource
variable across all subs, you could just check for it here:(I think the plugin system is lenient enough to allow the comma at the start even if no other tags came in, but might be good to check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch, thanks. I will put it after the no tags check on line 65 so adding strings like that should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it was awkward to test so I decided to carry $addsource across the subs after all.