Skip to content

Final delay values 'zf' #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ybourdin opened this issue Apr 16, 2025 · 1 comment
Open

Final delay values 'zf' #21

ybourdin opened this issue Apr 16, 2025 · 1 comment

Comments

@ybourdin
Copy link

Hello,
Thank you for your work.
It would be great to be able to get the final delay values 'zf' like with scipy.signal.lfilter, so that on the next calls to sample_wise_lpc with consecutive buffers, one can pass zi = zf.
zf can be obtained like this, but it's not so obvious:

y1 = sample_wise_lpc(x[:, :L], a, zi=None)
order = a.size(-1)
zf = y1[: -order:].flip(1)
y2 = sample_wise_lpc(x[:, L:), a, zi=zf)
@yoyolicoris
Copy link
Member

yoyolicoris commented Apr 16, 2025

Hi @ybourdin , glad to know you're interested in our work!
Good suggestion!
I suggest having a separate function like sample_wise_lpc_zf that implements what you describe and returns a tuple (y, zf) so we don't introduce backwards incompatible changes.
Please feel free to submit a PR, and we'll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants