Added lines storing #134
Open
Added lines storing #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOLANICH
force-pushed
the
line-number
branch
from
02b6206
to
c356c36
Compare
jhermann
requested changes
Feb 28, 2017
src/configobj/__init__.py
Outdated
| @@ -472,6 +472,8 @@ def _initialise(self): | |||
| self.default_values = {} | |||
| self.extra_values = [] | |||
| self._created = False | |||
| # for lines | |||
| self.lines = {} | |||
There was a problem hiding this comment.
a better name would be source_map and the comment is redundant.
generally, your PR is missing docs + tests.
src/configobj/__init__.py
Outdated
| @@ -514,7 +516,7 @@ def _check(entry): | |||
| return val | |||
|
|
|||
|
|
|||
| def __setitem__(self, key, value, unrepr=False): | |||
| def __setitem__(self, key, value, unrepr=False, lines=None): | |||
There was a problem hiding this comment.
a better name would be position or line_range.
src/configobj/__init__.py
Outdated
| @@ -571,7 +573,8 @@ def __setitem__(self, key, value, unrepr=False): | |||
| else: | |||
| raise TypeError('Value is not a string "%s".' % value) | |||
| dict.__setitem__(self, key, value) | |||
|
|
|||
| if(lines != None): | |||
There was a problem hiding this comment.
just if lines:, also this is not PEP8 compliant.
KOLANICH
force-pushed
the
line-number
branch
from
228bab4
to
0689f60
Compare
|
From what I can see, there's still PEP8 violations. Please use pylint, or pep8 to check your changes, and please do not squash changes, add more commits to your branch. |
KOLANICH
force-pushed
the
line-number
branch
3 times, most recently
from
84323b5
to
c2e1c47
Compare
KOLANICH
force-pushed
the
line-number
branch
from
c2e1c47
to
a3f80c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.