Cleanup unrepr function and related code #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some cruft left around from the old implemention of unrepr, which can now be deleted. Not sure if the lazy import of ast is worthwhile but the implemention of that is now pretty harmless. Note this does remove the exported but unused, and only ever internally propogated, UnknownType exception type.
|
The coverage script appears to be broken, all the last prs I submitted are reporting "Coverage remained the same" at different percentages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some cruft left around from the old implemention
of unrepr, which can now be deleted.
Not sure if the lazy import of ast is worthwhile but the
implemention of that is now pretty harmless.
Note this does remove the exported but unused, and only
ever internally propogated, UnknownType exception type.
Also adds test coverage for some unrepr corner cases.