-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for loading config object from "<(/usr/bin/envsubst < template)" #187
Open
LucidOne
wants to merge
3
commits into
DiffSK:master
Choose a base branch
from
LucidOne:process_substitution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamim
suggested changes
Jul 6, 2019
LucidOne
force-pushed
the
process_substitution
branch
from
July 6, 2019 07:47
d6e42cb
to
6d166d9
Compare
LucidOne
added a commit
to LucidOne/configobj
that referenced
this pull request
Jul 6, 2019
LucidOne
force-pushed
the
process_substitution
branch
from
July 6, 2019 07:51
6d166d9
to
9d7a288
Compare
Co-Authored-By: Aliaksei Urbanski <mimworkmail@gmail.com>
LucidOne
force-pushed
the
process_substitution
branch
from
July 6, 2019 08:29
19db23a
to
ae4b6ab
Compare
I'm not sure why coverage dropped, but it looks like the tests work. |
Is there anything left to get this merged? |
Any update on this? |
Is it possible to get this merged? I'd like to improve the letsencrypt certbot docker container for doing dns based wildcard cert requests and this is blocking me. |
Would it help to rebase this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configobj has an issue being passed a file descriptor (/dev/fd) via process substitution.
os.path.isfile("/dev/fd/{{ anything }}")
returnsFalse
for file descriptors whileos.path.exists()
returnsTrue
.test.py
I'll update the PR with a test when I get a chance
This is needed in cloud environments where you may not want to store passwords on disk in an unencrypted form or have variables passed into a container environment.