Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comments on merge. #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve comments on merge. #212

wants to merge 1 commit into from

Conversation

j-bennet
Copy link

This fixes #171. If we're merging config2 into config1, then values from config2, if present, should override values from config1. The same thing needs to happen with comments, but currently it does not.

Related to dbcli/pgcli#1240.

  • Run the tests and make sure they're passing (invoke test).
  • Check for violations of code conventions (invoke check).
  • Make sure the documentation builds without errors (invoke build --docs).

I have an error running invoke check and could not resolve it by googling, would appreciate advice on that:

https://gist.github.com/j-bennet/392e90ed75873a69b465e32dd6763476

@j-bennet
Copy link
Author

@EliAndrewC or @robdennis, any chance you'd have the time to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments not preserved on merge
1 participant