-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting error #130 - changing @stop to pause() #143
Conversation
This appears to fix issue #130: #130 @Stop is depreciated in iron-router 0.7.0 and going forward we should use @Pause(). When @Stop is used in the entrySignOut route, BlazeLayout throws the following error in the console (client side): Exception from Deps recompute function: Error: BlazeLayout: Sorry, couldn't find a template named entrySignOut. Are you sure you defined it? Replaces @Stop with @Pause seems to fix the issue.
I'm getting an error on this: "Uncaught TypeError: undefined is not a function" at line 27 in router.coffee, i.e. where this switch occurred. Are you guys not getting that? |
Hmm, You have to change line 22 from:
to
|
Thanks for the quick reply Gerard. That didn't work though (it's also not on the router.coffee for this commit). Any other ideas? |
Sorry then. I didn't actually try this. I just know it was a change in On Tuesday, April 15, 2014, cinjon notifications@github.com wrote:
Sent from my mobile device. |
@cinjon I wasn't getting this error before, but I am getting it now. I am not sure what changed. But, I will try to dig into it when I can. |
I am also getting "Uncaught TypeError: undefined is not a function" on sign-out. I have @Pause() in line 27 of router.coffee. |
+1 I am also getting this error now. |
Ok; I think I may have gotten this one now. Take a look at iron-meteor/iron-router#620 Looks like the the issue is that pause needs to be passed as a parameter like so:
I put together a PR: #168 |
That worked for me. Thanks! |
Thank you @Art1Sec8 that fixed the problem! |
This appears to fix issue #130:
#130
@Stop is depreciated in iron-router 0.7.0 and going forward we should use @Pause(). When @Stop is used in the entrySignOut route, BlazeLayout throws the following error in the console (client side):
Exception from Deps recompute function: Error: BlazeLayout: Sorry, couldn't find a template named entrySignOut. Are you sure you defined it?
Replacing @Stop with @Pause seems to fix the issue.