Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DefaultValueAttributes #907

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Add support for DefaultValueAttributes #907

merged 2 commits into from
Oct 19, 2022

Conversation

coxp
Copy link

@coxp coxp commented Oct 18, 2022

Add support for DefaultValueAttribute on fields when using the XmlSerializer. Fixes #906

Copy link
Collaborator

@andersjonsson andersjonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Left a comment about a possible NullReferenceException, but it looks good otherwise

src/SoapCore/Meta/MetaBodyWriter.cs Outdated Show resolved Hide resolved
@andersjonsson andersjonsson merged commit 14e4c40 into DigDes:develop Oct 19, 2022
@andersjonsson
Copy link
Collaborator

Thanks again!

@coxp coxp deleted the wsdl-default-value-attributes branch October 19, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set minOccurs="0" for optional boolean fields with XmlSerializer
2 participants